Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in skip_initial_status #856

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix bug in skip_initial_status #856

merged 1 commit into from
Mar 26, 2024

Conversation

levaspb
Copy link
Contributor

@levaspb levaspb commented Feb 2, 2024

I have found a bug in in the merged PR that introduced the skip_initial_status feature. This bug unjustly leaves conditions stagnant when this feature is enabled in a custom plugin configuration. The root cause is that the conditions for the plugin aren't properly initialized. The PR implies that when skip_initial_status is set, the initialConditions function is called. As a result, custom plugins with skip_initial_status work correctly.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 2, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: levaspb / name: leva_spb (f24dbb1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @levaspb!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @levaspb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 2, 2024
@vteratipally
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2024
@hakman
Copy link
Member

hakman commented Feb 28, 2024

/lgtm
/assign @vteratipally

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@levaspb
Copy link
Contributor Author

levaspb commented Feb 28, 2024

/assign @sjenning

@levaspb
Copy link
Contributor Author

levaspb commented Mar 11, 2024

ping @sjenning for approval

@levaspb
Copy link
Contributor Author

levaspb commented Mar 11, 2024

/retest

@levaspb
Copy link
Contributor Author

levaspb commented Mar 18, 2024

all tests successfully passed
@sjenning please review

@hakman
Copy link
Member

hakman commented Mar 26, 2024

/cc @wangzhen127

@vteratipally
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, levaspb, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8cd92db into kubernetes:master Mar 26, 2024
11 checks passed
@a7i
Copy link

a7i commented Jul 17, 2024

amazing! tested this and it looks good 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@yujuhong yujuhong Awaiting requested review from yujuhong

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@sjenning sjenning

@hakman hakman

@vteratipally vteratipally

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@levaspb @k8s-ci-robot @vteratipally @hakman @a7i @sjenning